This repository was archived by the owner on Nov 7, 2018. It is now read-only.
Fix Entrypoint #53
Closed
Fix Entrypoint #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are not supposed to run this image with |
|
Did you test the newest version with for example https://github.com/pires/kubernetes-elasticsearch-cluster/blob/master/es-master.yaml ? Does it work? In any case, the old versions worked with |
|
Yes. I've updated that repo and it worked smoothly. |
|
@ruediste thank you for giving this a try but I don't think this PR is a proper fix. It's actually confusing, particularly because you also have a commit that does unrelated changes. I will be working on a fix but would again like to say thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change introduced to automatically set the JVM heap size introduced a regression: It was not possible to start the container with just
docker run --privileged quay/.../.../elasticsearch. You needed to always include/run.shas argument.I removed the entrypoint and replaced it with a combined
/run.shscript.