Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add .xz and increase performance of compression module #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 8, 2025
Merged

Add .xz and increase performance of compression module #875

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1832ef6
Add .xz and increase performance of compression module
ddelange Aug 18, 2025
9f081b3
Test all compression extensions
ddelange Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Test all compression extensions
  • Loading branch information
@ddelange
ddelange committed Aug 27, 2025
commit 9f081b3fc75d8dc39e58c4d980818a6260432be3
41 changes: 25 additions & 16 deletions tests/test_smart_open.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,28 +78,37 @@ def named_temporary_file(mode='w+b', prefix=None, suffix=None, delete=True):
logger.error(e)


def test_zst_write():
with named_temporary_file(suffix=".zst") as tmp:
with smart_open.open(tmp.name, "wt") as fout:
print("hello world", file=fout)
print("this is a test", file=fout)
def test_compression_extensions():
for extension in smart_open.compression.get_supported_extensions():
with named_temporary_file(suffix=extension) as tmp:
with smart_open.open(tmp.name, "wt") as fout:
print("hello world", file=fout)
print("this is a test", file=fout)

with smart_open.open(tmp.name, "rt") as fin:
got = list(fin)
with smart_open.open(tmp.name, "rt") as fin:
got = list(fin)

assert got == ["hello world\n", "this is a test\n"]
assert got == ["hello world\n", "this is a test\n"], f"Error for {extension=}, mode='wt'"

with named_temporary_file(suffix=extension) as tmp:
with smart_open.open(tmp.name, "w") as fout:
fout.write("hello world\n")
fout.write("this is a test\n")

def test_zst_write_binary():
with named_temporary_file(suffix=".zst") as tmp:
with smart_open.open(tmp.name, "wb") as fout:
fout.write(b"hello world\n")
fout.write(b"this is a test\n")
with smart_open.open(tmp.name, "r") as fin:
got = list(fin)

with smart_open.open(tmp.name, "rb") as fin:
got = list(fin)
assert got == ["hello world\n", "this is a test\n"], f"Error for {extension=}, mode='w'"

assert got == [b"hello world\n", b"this is a test\n"]
with named_temporary_file(suffix=extension) as tmp:
with smart_open.open(tmp.name, "wb") as fout:
fout.write(b"hello world\n")
fout.write(b"this is a test\n")

with smart_open.open(tmp.name, "rb") as fin:
got = list(fin)

assert got == [b"hello world\n", b"this is a test\n"], f"Error for {extension=}, mode='wb'"


class ParseUriTest(unittest.TestCase):
Expand Down