-
Notifications
You must be signed in to change notification settings - Fork 36
Updated dining tests #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated dining tests #165
Conversation
|
Edited the PR description to automatically link the PR to the correct issue |
tianyizheng02
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests look good, I think. Where do the contents of the new JSON files come from, BTW?
The tests that are failing don't have anything to do with the dining module, gonna try to take a look at the code to see if there are any patterns. |
Co-authored-by: Tianyi Zheng <[email protected]>
Co-authored-by: Tianyi Zheng <[email protected]>
I just copied the exact data that would be returned from the Dine on Campus at the specific endpoints called by the sample function calls. I don't have much experience writing tests so I'm not sure if there was anything wrong with my approach. |
OK, I'm pretty sure the failing tests are failing because their inputs aren't mocked. The failing tests in TL;DR the tests in |
Fixes #164
Updated tests for functions in new Dining module
Added mocks for dining locations, dining menu, and dining schedule