Add cross-origin-frame-redact tests; bump coverage ratchet#139
Merged
Conversation
Brings cross-origin-frame-redact.ts from 18.75% to 93.75% statements (0% to 100% functions). Covers origin resolution across http(s)/srcdoc/ about/data/javascript/blob/invalid URLs, same-origin retention, the REVEALED_ATTR reveal flow, lazy injection via the subtree watcher, and teardown. With cross-origin-frame-redact now tested, ratchet thresholds up to sit just below the new baseline — global 60/50/55/60 → 62/58/58/61, and src/rules 75/58/75/75 → 84/71/88/84. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cross-origin-frame-redact.tsfrom 18.75% → 93.75% statements (0% → 100% functions). Adds 18 tests covering origin resolution across http(s)/srcdoc/about/data/javascript/blob/invalid URLs, same-origin retention, the REVEALED_ATTR reveal flow, lazy injection via the subtree watcher, and teardown.coverageThresholdratchet to sit just under the new baseline — global 60/50/55/60 → 62/58/58/61,src/rules/75/58/75/75 → 84/71/88/84. Updates the in-config comment to noteirrelevant-sections-redactas the remaining untested rule.Test plan
bun run preflightpasses (lint + typecheck + knip + jest with coverage)globaland./src/rules/🤖 Generated with Claude Code