Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix cross-origin-frame-redact watcher missing top-level iframes #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
twschiller merged 1 commit into from
Jun 5, 2026
Merged

Fix cross-origin-frame-redact watcher missing top-level iframes #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions extension/src/rules/__tests__/cross-origin-frame-redact.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,24 @@ describe("crossOriginFrameRedactRule", () => {
expect(getPlaceholder()).not.toBeNull();
});

// Regression: when an iframe is appended directly (no wrapper), the
// MutationObserver root *is* the iframe, and querySelectorAll on it
// returns nothing. The watcher must rescan from document.body to catch
// this case.
it("replaces a bare cross-origin iframe appended directly to body", async () => {
crossOriginFrameRedactRule.apply(document.body);

const iframe = document.createElement("iframe");
iframe.src = "https://example.com/widget";
document.body.append(iframe);

await flushMutations();
jest.advanceTimersByTime(MUTATION_THROTTLE_MS);

expect(document.querySelector("iframe")).toBeNull();
expect(getPlaceholder()).not.toBeNull();
});

it("teardown stops the observer so later additions are ignored", async () => {
crossOriginFrameRedactRule.apply(document.body);
crossOriginFrameRedactRule.teardown();
Expand Down
11 changes: 7 additions & 4 deletions extension/src/rules/cross-origin-frame-redact.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,13 @@ function scan(root: ParentNode): void {
}

const watcher = createSubtreeWatcher({
onSubtrees: (roots) => {
for (const root of roots) {
scan(root);
}
// MutationObserver hands us the newly-inserted element itself, but
// querySelectorAll on that element does not match the element itself —
// so a bare cross-origin <iframe> appended directly to document.body
// would be missed. Rescan from document.body on every batch; the
// is-connected / is-revealed checks in scan() keep it idempotent.
onSubtrees: () => {
scan(document.body);
},
skipPlaceholderSubtrees: true,
});
Expand Down
Loading