Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Cover prompt-injection-redact findContainer escalation paths #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
twschiller merged 1 commit into from
Jun 5, 2026
Merged

Cover prompt-injection-redact findContainer escalation paths #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions extension/jest.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,10 @@ module.exports = {
lines: 68,
},
"./src/rules/": {
statements: 90,
branches: 77,
functions: 95,
lines: 90,
statements: 91,
branches: 78,
functions: 96,
lines: 91,
},
},
};
36 changes: 36 additions & 0 deletions extension/src/rules/__tests__/prompt-injection-redact.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,4 +176,40 @@ describe("prompt-injection-redact", () => {
expect(document.querySelector(`.${PLACEHOLDER_CLASS}`)).toBeNull();
expect(document.body.textContent).toContain(FIXTURES.IGNORE_ALL);
});

describe("findContainer escalation", () => {
// When injection text lives directly in <body> with no block-level
// ancestor, the rule must not redact — wrapping <body> in a placeholder
// would black out the whole page. findContainer returns null on the
// BODY/HTML guard.
it("does not redact text that is a direct child of <body>", () => {
document.body.innerHTML = "";
document.body.append(document.createTextNode(FIXTURES.IGNORE_ALL));

promptInjectionRedactRule.apply(document.body);

expect(document.querySelector(`.${PLACEHOLDER_CLASS}`)).toBeNull();
expect(document.body.textContent).toContain(FIXTURES.IGNORE_ALL);
});

// When the only ancestor is a non-block element (a bare <div>/<span>/etc.
// not in BLOCK_CONTAINER_SELECTOR), the rule falls back to that direct
// parent rather than escalating. Confirms the "return parent" branch.
it("wraps the direct parent when no block-level ancestor matches", () => {
document.body.innerHTML = `<div id="wrap"><span id="leaf">${FIXTURES.IGNORE_ALL}</span></div>`;

promptInjectionRedactRule.apply(document.body);

// The <span> is the direct parent of the text node and not in the
// block selector — it gets replaced rather than escalating to <body>.
expect(document.querySelector("#leaf")).toBeNull();
expect(document.querySelector("#wrap")).not.toBeNull();
const placeholder = document.querySelector(`.${PLACEHOLDER_CLASS}`);
expect(placeholder).not.toBeNull();
// Placeholder sits inside the wrapper, not in place of the wrapper.
expect(
document.querySelector("#wrap")?.contains(placeholder ?? null),
).toBe(true);
});
});
});
Loading