Fix: scroll to top on SPA navigation in demo site#163
Merged
Conversation
Clicking the brand logo from mid-page on a product detail updated the URL and rendered the Home page, but BrowserRouter preserved the scroll position — so the user landed in the middle of the new page and the hero never came into view, making it look like nothing changed. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BrowserRouterpreserved the scroll position — the user landed mid-page on Home and the hero never came into view, so it looked like nothing changed.useLayoutEffectkeyed onpathnameinAppthat scrolls to top on every SPA navigation.Test plan
bun run checkpasses/to product detail and back via Playwright.🤖 Generated with Claude Code