Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix: leet detector firing on prose with version numbers (encoded-payload FP) #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
twschiller merged 1 commit into from
Jun 9, 2026
Merged

Fix: leet detector firing on prose with version numbers (encoded-payload FP) #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions extension/src/rules/__tests__/encoded-payload-redact.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,6 +541,22 @@ describe("encoded-payload-redact text-cipher false-positive guards", () => {
expect(document.querySelector(`.${PLACEHOLDER_CLASS}`)).toBeNull();
});

it("leaves English prose carrying a leet-shaped version number alone", () => {
// Real changelog copy: a version string like "11.16.0" supplies four
// leet-shape digits (1,1,1,0), clearing the substitution-count floor.
// The text is already English, so `deleet` leaves it readable and it
// would clear the common-word floor on its own — the already-English
// gate is what keeps it visible. (github.blog npm v12 changelog FP.)
const prose =
"Upgrade to npm 11.16.0 or later, run your normal install, and " +
"review the warnings.";
document.body.innerHTML = `<p>${prose}</p>`;
encodedPayloadRedactRule.apply(document.body);

expect(document.querySelector(`.${PLACEHOLDER_CLASS}`)).toBeNull();
expect(document.body.textContent).toContain(prose);
});

it("leaves a sparse dot/dash ASCII-art run alone (Morse valid-ratio floor)", () => {
// Repeating `--- . --- . ---` style separators — many tokens but
// most decode to letters with no decoded common-word hits, and the
Expand Down
17 changes: 14 additions & 3 deletions extension/src/rules/encoded-payload-redact.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,9 +321,10 @@ function reverseText(text: string): string {

// Leetspeak substitution table — only the substitutions that obscure a
// letter behind a digit or symbol. Pure digits (`2nd`, `iPhone 13`) get
// mapped too, which on its own would be a false positive; the
// surrounding gate requires a minimum substitution count AND a decoded
// common-word floor, so prose with incidental digits doesn't qualify.
// mapped too, which on its own would be a false positive; the surrounding
// gate requires a minimum substitution count, an already-English skip (so
// prose carrying incidental version-number digits like `11.16.0` is left
// alone), and a decoded common-word floor.
const LEET_MAP: Record<string, string> = {
"0": "o",
"1": "i",
Expand Down Expand Up @@ -747,6 +748,16 @@ function collectLeet(text: string, matches: InlineMatch[]): void {
) {
continue;
}
// Same already-English gate the substitution ciphers use: deleet leaves
// genuine letters untouched, so ordinary prose carrying incidental
// leet-shaped digits (version strings like `11.16.0`, dates) survives
// `deleet` essentially unchanged and would clear the common-word floor
// on its own. A real leet payload obscures its letters behind digits, so
// its *raw* form is not yet English. Skip candidates that already read as
// English — only an actual encode reveals a hidden directive.
if (alreadyEnglish(candidate, SUB_RULES.leetspeak.minCommonWords)) {
continue;
}
if (
tryCipherDecode(candidate, deleet, SUB_RULES.leetspeak.minCommonWords) !==
null
Expand Down
Loading