Chore(deps-dev): Bump eslint-plugin-unicorn from 64.0.0 to 66.0.0 in /extension#276
Merged
twschiller merged 2 commits intoJun 22, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bumps [eslint-plugin-unicorn](https://github.com/sindresorhus/eslint-plugin-unicorn) from 64.0.0 to 66.0.0. - [Release notes](https://github.com/sindresorhus/eslint-plugin-unicorn/releases) - [Commits](sindresorhus/eslint-plugin-unicorn@v64.0.0...v66.0.0) --- updated-dependencies: - dependency-name: eslint-plugin-unicorn dependency-version: 65.0.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
5f1ea85 to
edfc964
Compare
eslint-plugin-unicorn 66 enabled many new recommended rules. Apply the cleanly autofixable ones in-tree, downgrade the non-autofixable rules to warnings so the bump lands without a mass manual rewrite, and turn off three whose autofix is unsafe/redundant here: - comment-content: rewrites prose and real paths in comments - prefer-https: rewrites schema.org itemtype URIs and http test fixtures - require-css-escape: double-escapes values already handled by escapeAttributeValue and breaks on numeric interpolations filename-case sets checkDirectories:false to keep the Jest __tests__ / __test-mocks__ convention. Two no-unnecessary-global-this sites get inline disables where the global is deliberately accessed via globalThis (absent CSS in jsdom, typed chrome.scripting mock cast). Ratcheting the warnings back to errors is tracked in #279. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
twschiller
added a commit
that referenced
this pull request
Jun 22, 2026
From #279. Drop the redundant `globalThis.` prefix on the production Web-API call sites (the #276 autofix did property reads; it leaves method calls alone since dropping the object could in theory change `this` — safe for these standard globals): - placeholder, cookie-banner-hide, hidden-text-strip, newsletter-modal-hide, svg-sprite-strip, irrelevant-sections-redact: getComputedStyle - route-change: add/removeEventListener - use-tab-debug-trace, use-tab-pause: setInterval/clearInterval - yielding-text-walk: requestIdleCallback Disabled in the `src/**/__tests__/**` override: tests deliberately reach for `globalThis.*` to mock — overriding globals (`globalThis.MutationObserver = …`), dispatching events, and reading computed style against the jsdom global. So the test call sites keep `globalThis.` and a now-redundant inline disable in hidden-fee-annotate.test.ts is dropped. Rule is error everywhere else (reverts to unicorn/recommended default). Refs #279 Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps eslint-plugin-unicorn from 64.0.0 to 66.0.0.
Release notes
Sourced from eslint-plugin-unicorn's releases.
... (truncated)
Commits
ea3a05966.0.0250662cMeta tweaks1c85dd1Harden some rules with type info (#3228)f6b7fc4Document linting inAGENTS.mdd1b6ba7Addno-unsafe-property-keyrule (#3227)d116a6bAddconsistent-class-member-orderrule (#3226)174d5a5prefer-array-from-map: Supportfor-ofarray mapping (#3220)b752111Addno-useless-template-literalsrule (#3225)15332d1Disable smoke test workflow (#3224)74be15eAddno-optional-chaining-on-undeclared-variablerule (#3223)