Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Ratchet unicorn/no-global-object-property-assignment to error (off in tests) #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
twschiller merged 1 commit into from
Jun 22, 2026
Merged

Ratchet unicorn/no-global-object-property-assignment to error (off in tests) #283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion extension/eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,9 @@ export default tseslint.config(
"unicorn/require-array-sort-compare": "warn",
"unicorn/prefer-uint8array-base64": "warn",
"unicorn/no-declarations-before-early-exit": "warn",
"unicorn/no-global-object-property-assignment": "warn",
// no-global-object-property-assignment stays at its recommended `error`
// for production code; it's disabled only for tests (which legitimately
// assign globals to set up mocks) in the test-files block below.
"unicorn/prefer-minimal-ternary": "warn",
"unicorn/prefer-iterator-to-array": "warn",
"unicorn/no-incorrect-query-selector": "warn",
Expand Down Expand Up @@ -251,6 +253,9 @@ export default tseslint.config(
// Tests legitimately use literal nulls and many small `for` loops.
"unicorn/no-useless-undefined": "off",
"unicorn/consistent-function-scoping": "off",
// Tests assign onto global objects to install mocks / stubs; the rule
// stays an error everywhere else.
"unicorn/no-global-object-property-assignment": "off",
// Jest matchers and mock patterns routinely pass methods by reference.
"@typescript-eslint/unbound-method": "off",

Expand Down
Loading