Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Disable unicorn/prefer-scoped-selector (#279) #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
twschiller merged 1 commit into from
Jun 22, 2026
Merged

Disable unicorn/prefer-scoped-selector (#279) #297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion extension/eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,8 +261,25 @@ export default tseslint.config(
// both of which `Number()` would mis-coerce.
"unicorn/prefer-number-coercion": "error",

// Off — the rule's `:scope` rewrite is unsound for this codebase's
// dominant receiver type. It assumes the query receiver is an Element,
// where `el.querySelectorAll("foo")` and `el.querySelectorAll(":scope
// foo")` are equivalent. But our shadow-piercing scanners take
// `root: ParentNode` and run against `Document`, `ShadowRoot`, and
// `DocumentFragment` receivers at runtime — where `:scope` is NOT
// equivalent: it matches nothing on a ShadowRoot/DocumentFragment
// (so `:scope *`/`:scope noscript` silently return empty) and excludes
// `<html>` on a Document. Mechanically applying the suggestion would
// silently disable defenses inside shadow DOM (noscript-strip,
// hidden-text-strip, unicode-invisibles-strip, trust-badge-annotate,
// closed-shadow-root-annotate, …). The Element-receiver sites where
// `:scope` *is* safe are all single-compound selectors with no
// descendant combinator, so there's no correctness upside there either.
// The rule can't narrow to Element receivers or combinator selectors,
// so enabling it means breaking shadow-DOM scans or scoped-disabling
// ~10+ correct sites. Not worth it. See #279.
"unicorn/prefer-scoped-selector": "off",
// Warn — ratchet to error in #279:
"unicorn/prefer-scoped-selector": "warn",
"unicorn/no-break-in-nested-loop": "warn",
// no-global-object-property-assignment stays at its recommended `error`
// for production code; it's disabled only for tests (which legitimately
Expand Down
Loading