fix: ensure correct parser for blob image paths in bitmap font loader #11585
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Explicitly sets parser to 'texture' for blob URLs in textureUrls
|
pixi.js-base • pixi.js-bunny-mark commit: |
| @@ -96,7 +96,8 @@ export const loadBitmapFont = { | |||
|
|
|||
| textureUrls.push({ | |||
| src: imagePath, | |||
| data: textureOptions | |||
| data: textureOptions, | |||
| parser: imagePath.startsWith('blob:') ? 'texture' : undefined | |||
There was a problem hiding this comment.
It would be much more useful if users could declare the parser to use rather than assuming every blob is a texture.
Assets.load({ src: "path/to/font.fnt", data: { imageParser: "ktx" } })This way it would easily support ktx, basis and other compressed texture types.
bigtimebuddy
requested changes
Aug 20, 2025
There was a problem hiding this comment.
@ragePowered thanks so much for this change. Blobs are definitely an area that we could use more support.
The best way for us to solve this one is, like my comment above suggest, to allow the texture parser to be configurable through the asset's data. Is this something that you could look at and maybe create a test for?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This pull request extends BitmapFont support in PixiJS 8 to allow using Blob URLs as texture sources.
Previously, loadBitmapFont relied solely on file extensions to determine the appropriate loader, which fails for blob URLs (since they have no extension).
This change assumes that any file referenced within the .fnt file is a texture (e.g. PNG, JPG, WEBP, AVIF, or a Blob representing one of these formats), and treats it accordingly.
Potential impact:
This may affect cases where compressed textures (e.g. .ktx, .basis, etc.) are used as .fnt texture pages. Their handling is not explicitly addressed here and might require additional logic.
Pre-Merge Checklist
npm run lint)npm run test)