Allow insecure URLs with config option #136
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…han overriding the default
|
@samlaycock I started on some tweaks with your pull request, but gonna look more closely at this later, there were some ideas around another direction we can take with this. |
|
@iheanyi sure thing, thanks for responding and jumping on this |
|
Okay @samlaycock , we took a different approach for this in #138. The latest 1.11 version of the driver should work with letting you set a local dev URL using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the discussion over in #135 , this adds an
allowInsecureConnectionoption to theconnect()method that allows the use ofhttpas protocol when explicitly set totrue.