This repository was archived by the owner on Feb 9, 2019. It is now read-only.
Correctly identify Windows hosts when os.name property starts with "win"#23
Open
sjmurdoch wants to merge 1 commit intoplayframework:masterfrom
Open
Correctly identify Windows hosts when os.name property starts with "win"#23sjmurdoch wants to merge 1 commit intoplayframework:masterfrom
sjmurdoch wants to merge 1 commit intoplayframework:masterfrom
Conversation
…indows"
os.indexOf("win") <= 0 will return true if "win" is not found *or* the string starts with
"win". This will improperly treat platforms which start with "win", e.g. "Windows 7" as if
they are *nix. Testing os.indexOf("win") < 0 will return true only if "win" is not found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
os.indexOf("win") <= 0 will return true if "win" is not found or the string starts with
"win". This will improperly treat platforms which start with "win", e.g. "Windows 7" as if
they are *nix. Testing os.indexOf("win") < 0 will return true only if "win" is not found.
When a Windows host is treated as if it is *nix, the request to load the "c" native library fails,
resulting in:
This appears to be the same problem encountered by this user: https://groups.google.com/d/msg/play-framework/i86yduDeMPU/24A6E8Kk5m0J