Compile error triggers multiple compilations #7753
Description
Normally, when I screw up my code and "run" my app, refreshing the web browser causes play to compile, fail, and return a "Compilation failed" page. Since upgrading to 2.6, refreshing the browser will cause the code to enter a (compile, fail, repeat) loop. It attempts to compile four times before finally returning to the browser after the last failure. I thought it was Chrome being clever and re-requesting the page, but I've reproduced it with curl as well.
Play Version
2.6.X (tested with 2.6.3)
API
Scala (maybe both)
Operating System (Ubuntu 15.10 / MacOS 10.10 / Windows 10)
MacOS Sierra
Expected Behavior
- Introduce compile error in project.
- Start the app with
run. - Refresh the browser or curl url.
- Play will attempt to compile once, fail, and return a "Compilation failed" page
Actual Behavior
- Introduce compile error in project.
- Start the app with
run. - Refresh the browser or curl url.
- Play will attempt to compile four times, before returning a "Compilation failed" page
Reproducible Test Case
sbt new playframework/play-scala-seed.g8- Introduce compile error in project (add a few random characters to the controller).
- Start the app with
run. - Refresh the browser or curl url.
- Play will attempt to compile four times.
[info] Compiling 1 Scala source to /Users/kyle/Temp/xxx/target/scala-2.12/classes...
[error] /Users/kyle/Temp/xxx/app/controllers/HomeController.scala:22: value xxx is not a member of play.api.mvc.Result
[error] Ok(views.html.index())xxx
[error] ^
[error] one error found
[error] (compile:compileIncremental) Compilation failed
[info] Compiling 1 Scala source to /Users/kyle/Temp/xxx/target/scala-2.12/classes...
[error] /Users/kyle/Temp/xxx/app/controllers/HomeController.scala:22: value xxx is not a member of play.api.mvc.Result
[error] Ok(views.html.index())xxx
[error] ^
[error] one error found
[error] (compile:compileIncremental) Compilation failed
[error] application -
! @7559l0cdj - Internal server error, for (GET) [/] ->
play.sbt.PlayExceptions$CompilationException: Compilation error[value xxx is not a member of play.api.mvc.Result]
at play.sbt.PlayExceptions$CompilationException$.apply(PlayExceptions.scala:27)
at play.sbt.PlayExceptions$CompilationException$.apply(PlayExceptions.scala:27)
at scala.Option.map(Option.scala:145)
at play.sbt.run.PlayReload$$anonfun$taskFailureHandler$1.apply(PlayReload.scala:49)
at play.sbt.run.PlayReload$$anonfun$taskFailureHandler$1.apply(PlayReload.scala:44)
at scala.Option.map(Option.scala:145)
at play.sbt.run.PlayReload$.taskFailureHandler(PlayReload.scala:44)
at play.sbt.run.PlayReload$.compileFailure(PlayReload.scala:40)
at play.sbt.run.PlayReload$$anonfun$compile$1.apply(PlayReload.scala:17)
at play.sbt.run.PlayReload$$anonfun$compile$1.apply(PlayReload.scala:17)
[info] Compiling 1 Scala source to /Users/kyle/Temp/xxx/target/scala-2.12/classes...
[error] /Users/kyle/Temp/xxx/app/controllers/HomeController.scala:22: value xxx is not a member of play.api.mvc.Result
[error] Ok(views.html.index())xxx
[error] ^
[error] one error found
[error] (compile:compileIncremental) Compilation failed
[info] Compiling 1 Scala source to /Users/kyle/Temp/xxx/target/scala-2.12/classes...
[error] /Users/kyle/Temp/xxx/app/controllers/HomeController.scala:22: value xxx is not a member of play.api.mvc.Result
[error] Ok(views.html.index())xxx
[error] ^
[error] one error found
[error] (compile:compileIncremental) Compilation failed