Avoid multiple calls to ApplicationProvider#get for a single request #8166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Also fixes #7650 - thanks! I can review this tomorrow if you like. |
Member
Author
|
👍 A review would be great. I'm not totally happy with the way the code is structured now so I wonder if you have ideas on how to do it more elegantly. |
Member
richdougherty
left a comment
There was a problem hiding this comment.
LGTM - I have lots of ideas for changing how the whole request pipeline works (see #8005), but this looks like a good incremental step.
richdougherty
approved these changes
Jan 17, 2018
Member
richdougherty
left a comment
There was a problem hiding this comment.
(Meant to approve in last review)
gmethvin
added a commit
to gmethvin/playframework
that referenced
this pull request
Jan 17, 2018
gmethvin
added a commit
to gmethvin/playframework
that referenced
this pull request
Jan 18, 2018
gmethvin
added a commit
to gmethvin/playframework
that referenced
this pull request
Jan 18, 2018
gmethvin
added a commit
to gmethvin/playframework
that referenced
this pull request
Jan 24, 2018
gmethvin
added a commit
that referenced
this pull request
Jan 24, 2018
Member
|
Regarding the comment above:
I guess we can close #7650 now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell,
ApplicationProvider#getis not meant to be called multiple times for the same request. It looks like that was the case previously, but in 2.6.x we've added some caching based on theTry[Application]instance and are calling theApplicationProviderto get the current instance each time. The current dev mode reload logic forces a reload next time (forceReloadNextTime = true) when compilation fails, so ifgetis called more than once for a single request, that causes multiple compilations per request.My solution here proposes to get the
Try[Application]once and pass that instance around for the handling of the request.Fixes #7753