Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[3.0.x] Fix jjwt 0.12 compatibility for setExpiration method #12818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mkurz merged 2 commits into from
Jul 28, 2024
Merged

[3.0.x] Fix jjwt 0.12 compatibility for setExpiration method #12818

mkurz merged 2 commits into from
Jul 28, 2024

Conversation

@PromanSEW
Copy link
Contributor

@PromanSEW PromanSEW commented Jul 28, 2024 •
edited
Loading

Pull Request Checklist

Helpful things

Fixes

Fixes #12817

Purpose

Fix for JwtBuilder.setExpiration method which become expiration in 0.12+

References

#12817, #12624, #12626

@PromanSEW
Copy link
Contributor Author

PromanSEW commented Jul 28, 2024 •
edited
Loading

I don't know how to correctly test the fix, except adding config setting. Are any other checks needed?

@mkurz
Copy link
Member

mkurz commented Jul 28, 2024

Are any other checks needed?

@PromanSEW actually not. However can you do the following?

  1. First push your second commit, where you add the config to tests. Let all the tests run, we should then see the error.
  2. After that push the fix and we will then see the commit fixes the problem.

@PromanSEW PromanSEW mentioned this pull request Jul 28, 2024
Closed
@PromanSEW
Copy link
Contributor Author

PromanSEW commented Jul 28, 2024

@mkurz #12819 confirmed that my fix worked

@mkurz
Copy link
Member

mkurz commented Jul 28, 2024

Thanks! Actually I meant to rebase this PR and first push the test commit, wait for the tests, and then push the second commit. Anyway, LGTM!

@mkurz mkurz merged commit 59b1fcc into playframework:3.0.x Jul 28, 2024
@mkurz
Copy link
Member

mkurz commented Jul 28, 2024

@Mergifyio backport 2.9.x

@mergify
Copy link
Contributor

mergify bot commented Jul 28, 2024 •
edited
Loading

backport 2.9.x

✅ Backports have been created

Details

@mkurz mkurz mentioned this pull request Jul 28, 2024
Closed
@mergify mergify bot mentioned this pull request Jul 28, 2024
Merged
7 tasks
mergify bot added a commit that referenced this pull request Jul 28, 2024
@mergify
Merge pull request #12820 from playframework/mergify/bp/2.9.x/pr-12818
2f948a1 
[2.9.x] Fix jjwt 0.12 compatibility for `setExpiration` method (backport #12818) by @PromanSEW
@PromanSEW PromanSEW deleted the patch-1 branch July 29, 2024 03:16
@mkurz mkurz added this to the 3.0.6 milestone Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0.6

Development

Successfully merging this pull request may close these issues.

2 participants

@PromanSEW @mkurz