Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@RommelTJ
Copy link
Contributor

@RommelTJ RommelTJ commented Oct 4, 2024

Resolves #10572

Pull Request Checklist

Helpful things

Fixes

Closes #10572

Purpose

Updates AssetsOverview.md with documentation on the behavior of the Last-Modified header. Includes an explanation of the issue, and a workaround.

Background Context

  1. Built a Hello World application using Play Framework.
  2. Added this line to build.sbt: ThisBuild / packageOptions += Package.FixedTimestamp(Package.keepTimestamps).
  3. Built with sbt clean universal:packageZipTarball.
  4. Deployed app and sent a GET request to {host}/assets/images/favicon.png and inspected the image headers. Verified the Last-Modified header is now correctly set.
  5. Updated documentation.

References

Copy link
Member

@mkurz mkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mergify
Copy link
Contributor

mergify bot commented Feb 18, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@mkurz
Copy link
Member

mkurz commented Feb 18, 2025

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Feb 18, 2025

rebase

✅ Branch has been successfully rebased

@mkurz mkurz force-pushed the deploy-header-docs branch from 0594138 to 8e2b35e Compare February 18, 2025 22:40
@mkurz
Copy link
Member

mkurz commented Feb 18, 2025

@Mergifyio backport 3.0.x 2.9.x

@mergify
Copy link
Contributor

mergify bot commented Feb 18, 2025

backport 3.0.x 2.9.x

✅ Backports have been created

Details

@mergify
Copy link
Contributor

mergify bot commented Feb 18, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@mkurz mkurz merged commit f19de36 into playframework:main Feb 18, 2025
29 of 31 checks passed
mergify bot added a commit that referenced this pull request Feb 19, 2025
[3.0.x] Documentation Update: Asset timestamp handling with sbt (backport #12895) by @RommelTJ
mergify bot added a commit that referenced this pull request Feb 19, 2025
[2.9.x] Documentation Update: Asset timestamp handling with sbt (backport #12895) by @RommelTJ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Last-Modified HTTP header of assets contained in jar is wrong when using sbt >= 1.4.0

3 participants