Avoid error at shutdown if tmpdir is not writeable but was not used in the first place (alternative PR) #13110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry folder (fix playframework#13013) With a read-only filesystem, an error was raised during shutdown when trying to delete the temporary folder because delete would first create the folder if it was not yet created. fix playframework#13013
Merged
7 tasks
mkurz
commented
Feb 16, 2025
| private lazy val playTempFolder: Path = { | ||
| private val TempDirectoryPrefix = "playtemp" | ||
| private var _playTempFolder: Option[Path] = None | ||
| private def playTempFolder: Path = _playTempFolder.getOrElse { |
Member
Author
There was a problem hiding this comment.
So we have a failing test now:
[error] x not have a race condition when creating temporary files (794 ms)
[error] the value is false (TemporaryFileCreatorSpec.scala:90)
The test ends with this line:
So the problem is the code _playTempFolder.getOrElse { ... } is not atomic. Multiple threads can enter the getOrElse { ... } body, create a new tempfolder and update the _playTempFolder var and the `temporaryFileReaper´ tmp folder.
So this alternative does not work without syncing some code, therefore lets just merge #13039 instead.
Member
There was a problem hiding this comment.
Oh right, I thought about it for a sec and said to myself "we don't really care" but that's nice that a test caught it :) Because now that I think about it more, we do care! It could lead to some inconsistencies and not clean things properly at shutdown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have a preference, I just tried who thinks look like with the
Optionapproach.