Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bugfix for reverse routing when using F.Option #3533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jroper merged 1 commit into from
Oct 23, 2014
Merged

Bugfix for reverse routing when using F.Option #3533

jroper merged 1 commit into from
Oct 23, 2014

Conversation

@mkurz
Copy link
Member

@mkurz mkurz commented Oct 22, 2014

Using latest 2.4-SNAPSHOT or latest 2.3-SNAPSHOT with following routes:

GET     /JOptionNull                controllers.Application.jOptionRoute(id: play.libs.F.Option[Integer] = play.libs.F.Option.None[Integer])
GET     /JOptionValue               controllers.Application.jOptionRoute(id: play.libs.F.Option[Integer] = play.libs.F.Option.Some(12345))
GET     /JOptionValue1              controllers.Application.jOptionRoute(id: play.libs.F.Option[Integer] = play.libs.F.Option.Some(98765))
GET     /JOptionValue2              controllers.Application.jOptionRoute(id: play.libs.F.Option[Integer])

In a template having reverse routes for them:

@routes.Application.jOptionRoute(play.libs.F.Option.None())
@routes.Application.jOptionRoute(play.libs.F.Option.Some(12345))
@routes.Application.jOptionRoute(play.libs.F.Option.Some(98765))
@routes.Application.jOptionRoute(play.libs.F.Option.Some(11111))

Gives me the following routes:

/JOptionValue2
/JOptionValue2?id=12345
/JOptionValue2?id=98765
/JOptionValue2?id=11111

Which is wrong! Correct would be:

/JOptionNull
/JOptionValue
/JOptionValue1
/JOptionValue2?id=11111

Only when using F.Option reverse routing is "broken" - it works fine with any other type (Long, java.lang.Long, java.util.UUID, Int, java.lang.Integer and even with Scala Option).

The cause for this bug is that in target/scala-2.11/src_managed/main/routes_reverseRouting.scala Scala code like this gets generated:

def jOptionRoute(id:play.libs.F.Option[Integer]): Call = {
...
case (id) if id == play.libs.F.Option.None[Integer] =>
...
case (id) if id == play.libs.F.Option.Some(12345) =>
...
case (id) if id == play.libs.F.Option.Some(98765) =>
...
}

But F.Option does not have an equals (and hashCode) method, so all of the above conditions will always be false!

play.libs.F.Option.Some(12345) == play.libs.F.Option.Some(12345) // (in Scala) returns false - Bug!
play.libs.F.Option.Some(12345).equals(play.libs.F.Option.Some(12345)) // returns false - Bug!

This PR simply adds the equals/hashCode methods (including tests) to F.Option which as a consequence fixes the above reverse routing bug.

@mkurz mkurz changed the title Add equals() and hashCode() to play.libs.F.Option Bugfix for reverse routing when using F.Option Oct 22, 2014
@mkurz mkurz mentioned this pull request Oct 22, 2014
Merged
jroper added a commit that referenced this pull request Oct 23, 2014
@jroper
Merge pull request #3533 from mkurz/OptionEquals
31ff253 
Bugfix for reverse routing when using F.Option
@jroper jroper merged commit 31ff253 into playframework:master Oct 23, 2014
@jroper jroper added this to the 2.3.6 milestone Oct 28, 2014
@mkurz mkurz deleted the OptionEquals branch February 17, 2016 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.3.6

Development

Successfully merging this pull request may close these issues.

2 participants

@mkurz @jroper