Backport #3576: Add anorm support for parsing UUIDs from JDBC Strings #3582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or parsing UUIDs from JDBC Strings
f70c1f0 to
2ee14f6
Compare
Member
There was a problem hiding this comment.
I'd use try/catch here instead of Try/match. It's just a little bit simpler to use the native keywords unless you're using one of the features of Try.
try Right(UUID.fromString(s)) catch {
case NonFatal(_) => Left(TypeDoesNotMatch(...))
}
Member
Author
There was a problem hiding this comment.
I'd prefer to update it first on master, with another commit.
Either this one is put on hold, or it would be change by another backport.
Member
There was a problem hiding this comment.
That sounds fine to me. I don't think you should update this backport PR.
It's just a minor thing, but if you agree you could update it on master at
some point in the future.
richdougherty
added a commit
that referenced
this pull request
Oct 30, 2014
Backport #3576: Add anorm support for parsing UUIDs from JDBC Strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.