Added SubTypesScanner to Reflections factory in Classpath #4860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added SubTypesScanner to Reflections factory in Classpath class because getTypesAnnotatedWith method requires SubTypesScanner to be configured in Reflections version 0.9.9. Refactor duplicated creations of Reflections configuration to single method. Added test case for utility class Classpath.
Member
|
@marcospereira because you made some comments on the original issue #4831 - are we ok to backport this to the 2.4.x branch? |
Member
|
@mkurz the build here was executed by jenkins and I did not remember if it checks binary compatibility. I will close/reopen to see if travis starts a build for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports PR #4831 to 2.4.x.