Play WS only parses form body when used with OAuth - 2.4.x #5228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5e7392c to
3cd7d74
Compare
Member
Author
|
Templates timed out. @play-pull-request-validator again please. |
If parsing the form body, remove any explicitly user-defined Content-Length header. Add Java WS changes and tests Fix java tests
3cd7d74 to
ec87ea0
Compare
Member
|
This LGTM. Also, it should probably be forward ported to master. |
jroper
added a commit
that referenced
this pull request
Feb 15, 2016
Play WS only parses form body when used with OAuth - 2.4.x
Member
|
Forward port to master still needed. |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5221 in 2.4.x, by only parsing WS request body if signature calculator is present.