Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@richdougherty
Copy link
Member

Backport of #5343.

@benmccann
Copy link
Contributor

Looks like it's not backporting cleanly. Maybe we need to include some other dependency as well?

[error] /home/travis/build/playframework/playframework/framework/src/routes-compiler/src/main/scala/play/routes/compiler/RoutesFileParser.scala:10: object parsing is not a member of package util
[error] import scala.util.parsing.combinator._
[error] ^

@richdougherty
Copy link
Member Author

OK I can add that in by re-cherry-picking the backport. I thought the parser combinator stuff wasn't needed.

@richdougherty richdougherty force-pushed the cross-build-routes-compiler-2.4.x branch from e7b50d6 to 2b67cc0 Compare December 11, 2015 20:50
@richdougherty richdougherty force-pushed the cross-build-routes-compiler-2.4.x branch from 2b67cc0 to c398873 Compare December 13, 2015 21:48
@richdougherty
Copy link
Member Author

Test failure seems to be unrelated. I'll record the failure here for posterity:

[error]       x log a warning if sslConfig.default is passed in with an weak certificate
[error]        0 is equal to 0 (NingConfigSpec.scala:269)

@richdougherty
Copy link
Member Author

Tests froze for 10 mins. Probably related to test box flakiness.

No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself.

jroper added a commit that referenced this pull request Dec 14, 2015
…er-2.4.x

Cross-build support for routes compiler
@jroper jroper merged commit d7fdb4d into playframework:2.4.x Dec 14, 2015
@mkurz mkurz added this to the 2.4.6 milestone Dec 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants