Thanks to visit codestin.com
Credit goes to github.com

Skip to content

#5691 2.4.x backport: Make Akka.system use the system field on app #5692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gmethvin merged 1 commit into from
Feb 19, 2016
Merged

#5691 2.4.x backport: Make Akka.system use the system field on app #5692

gmethvin merged 1 commit into from
Feb 19, 2016

Conversation

@lloydmeta
Copy link
Contributor

@lloydmeta lloydmeta commented Feb 19, 2016

Simple backport of #5691 which fixes #4614 in case it comes in handy.

@richdougherty
Copy link
Member

richdougherty commented Feb 19, 2016

Test failures:

codeChecks:

java.lang.ArrayIndexOutOfBoundsException: 1515
    at com.typesafe.tools.mima.core.BufferReader.nextByte(BufferReader.scala:33)
    at com.typesafe.tools.mima.core.BufferReader.nextChar(BufferReader.scala:48)
    at com.typesafe.tools.mima.core.ClassfileParser.parseMembers(ClassfileParser.scala:216)
    at com.typesafe.tools.mima.core.ClassfileParser.parseFields(ClassfileParser.scala:208)
    at com.typesafe.tools.mima.core.ClassfileParser.parseClass(ClassfileParser.scala:261)
    at com.typesafe.tools.mima.core.ClassfileParser.parseAll(ClassfileParser.scala:68)
    at com.typesafe.tools.mima.core.ClassfileParser.parse(ClassfileParser.scala:59)
    at com.typesafe.tools.mima.core.ClassInfo.ensureLoaded(ClassInfo.scala:86)
    at com.typesafe.tools.mima.core.ClassInfo.methods(ClassInfo.scala:101)
    at com.typesafe.tools.mima.core.ClassInfo$$anonfun$lookupClassMethods$2.apply(ClassInfo.scala:123)
    at com.typesafe.tools.mima.core.ClassInfo$$anonfun$lookupClassMethods$2.apply(ClassInfo.scala:123)
    at scala.collection.Iterator$$anon$13.hasNext(Iterator.scala:371)
    at scala.collection.Iterator$$anon$12.hasNext(Iterator.scala:350)
    at scala.collection.Iterator$$anon$14.hasNext(Iterator.scala:388)
    at scala.collection.Iterator$class.foreach(Iterator.scala:727)
    at scala.collection.AbstractIterator.foreach(Iterator.scala:1157)
    at scala.collection.generic.Growable$class.$plus$plus$eq(Growable.scala:48)
    at scala.collection.mutable.ListBuffer.$plus$plus$eq(ListBuffer.scala:176)
    at scala.collection.mutable.ListBuffer.$plus$plus$eq(ListBuffer.scala:45)
    at scala.collection.TraversableOnce$class.to(TraversableOnce.scala:273)
    at scala.collection.AbstractIterator.to(Iterator.scala:1157)
    at scala.collection.TraversableOnce$class.toList(TraversableOnce.scala:257)
    at scala.collection.AbstractIterator.toList(Iterator.scala:1157)
    at com.typesafe.tools.mima.lib.analyze.method.BaseMethodChecker.check(MethodChecker.scala:13)
    at com.typesafe.tools.mima.lib.analyze.method.ClassMethodChecker.check(MethodChecker.scala:43)
    at com.typesafe.tools.mima.lib.analyze.method.ClassMethodChecker.check(MethodChecker.scala:38)

test:

[error]       x log a warning if sslConfig.default is passed in with an weak certificate
[error]        0 is equal to 0 (NingConfigSpec.scala:269)

I'll restart them both in case they're transient, but the first failure looks like a MIMA bug.

gmethvin added a commit that referenced this pull request Feb 19, 2016
@gmethvin
Merge pull request #5692 from lloydmeta/feature/akka-system-fix-2.4
f507d6e 
#5691 2.4.x backport:  Make Akka.system use the system field on app
@gmethvin gmethvin merged commit f507d6e into playframework:2.4.x Feb 19, 2016
@gmethvin
Copy link
Member

gmethvin commented Feb 19, 2016

@richdougherty It looks like the tests are good now,

@lloydmeta lloydmeta deleted the feature/akka-system-fix-2.4 branch February 19, 2016 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lloydmeta @richdougherty @gmethvin