allow i18n usage on weblogic #5764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when a play app is deployed as a war on weblogic, it fails as the classpath contains zip archives and isDirectory throws an Exception, rendering the usage of I18n unusable. Based on 422ca97.
4 tasks
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Purpose
Allow I18n usage of play apps on weblogic.
Background Context
Loading of I18n messages checks if items on the classpath are directories and breaks the application on unknown protocol e.g. "zip", which exists on weblogic installations.
References
Original commit introducing the breakage - 686a9b4
Fix for 2.3 branch - 422ca97 (PR #5728)
Fix for 2.4 branch - (PR #5763)