-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Ensure data parts don't take 5 seconds to parse #5860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure data parts don't take 5 seconds to parse #5860
Conversation
|
Could we add a timeout in the tests so this doesn't regress? It should be enough to add implicit val timeout = Timeout(1.second)to |
|
1 second is not long enough, travis can easily take longer than that, especially if a GC happens to occur at the same time. |
|
What about tagging it and exclude it from travis? Or add something to prune send multipart/body, etc..? |
|
@jroper Maybe 5 seconds? Those tests were taking 10 seconds each before. |
|
What about using Drone on vegemite? If we can leverage the metal we have for integration tests, it would probably be more reliable than Travis's platform. |
|
@wsargent Definitely something we should consider if we're cutting corners in our tests to make it run on Travis. Unless there is a way we can get travis to give us more resources. |
|
What about prune? I have the impression that such performance regression should have appeared there. |
|
Okay. I'm going to merge it as-is and we will look into testing for performance regressions elsewhere. @marcospereira prune might be a good place to do it. |
Ensure data parts don't take 5 seconds to parse
|
I believe this should be backported to 2.5.x, right? |
|
It was already backported here: c016361. |
Fixes #5751.