Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jroper
Copy link
Member

@jroper jroper commented Mar 11, 2016

Fixes #5751.

@gmethvin
Copy link
Member

Could we add a timeout in the tests so this doesn't regress?

It should be enough to add

implicit val timeout = Timeout(1.second)

to play.it.http.parsing.MultipartFormDataParserSpec.

@jroper
Copy link
Member Author

jroper commented Mar 11, 2016

1 second is not long enough, travis can easily take longer than that, especially if a GC happens to occur at the same time.

@schmitch
Copy link
Contributor

What about tagging it and exclude it from travis? Or add something to prune send multipart/body, etc..?

@gmethvin
Copy link
Member

@jroper Maybe 5 seconds? Those tests were taking 10 seconds each before.

@wsargent
Copy link
Member

What about using Drone on vegemite? If we can leverage the metal we have for integration tests, it would probably be more reliable than Travis's platform.

@gmethvin
Copy link
Member

@wsargent Definitely something we should consider if we're cutting corners in our tests to make it run on Travis. Unless there is a way we can get travis to give us more resources.

@marcospereira
Copy link
Member

What about prune? I have the impression that such performance regression should have appeared there.

@gmethvin
Copy link
Member

Okay. I'm going to merge it as-is and we will look into testing for performance regressions elsewhere. @marcospereira prune might be a good place to do it.

gmethvin added a commit that referenced this pull request Mar 11, 2016
Ensure data parts don't take 5 seconds to parse
@gmethvin gmethvin merged commit 8f66891 into playframework:master Mar 11, 2016
@marcospereira
Copy link
Member

I believe this should be backported to 2.5.x, right?

@marcospereira
Copy link
Member

It was already backported here: c016361.

@jroper jroper deleted the 5751-5-second-multipart-form-data branch May 11, 2016 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants