Test flake?

[error] ! close when the consumer is done
[error] java.util.concurrent.TimeoutException: Futures timed out after 5 seconds
[error] play.api.test.FutureAwaits$class.await(Helpers.scala:191)
[error] play.it.http.websocket.NettyWebSocketSpec$.await(WebSocketSpec.scala:29)
[error] play.it.http.websocket.WebSocketSpec$$anonfun$runWebSocket$1.apply(WebSocketSpec.scala:50)
[error] play.it.http.websocket.WebSocketSpec$$anonfun$runWebSocket$1.apply(WebSocketSpec.scala:48)
[error] play.it.http.websocket.WebSocketClient$.apply(WebSocketClient.scala:72)
[error] play.it.http.websocket.WebSocketSpec$class.runWebSocket(WebSocketSpec.scala:48)
[error] play.it.http.websocket.NettyWebSocketSpec$.runWebSocket(WebSocketSpec.scala:29)
[error] play.it.http.websocket.WebSocketSpec$$anonfun$closeWhenTheConsumerIsDone$2.apply(WebSocketSpec.scala:132)
[error] play.it.http.websocket.WebSocketSpec$$anonfun$closeWhenTheConsumerIsDone$2.apply(WebSocketSpec.scala:130)
[error] play.it.http.websocket.WebSocketSpec$$anonfun$withServer$1.apply(WebSocketSpec.scala:44)
[error] play.api.test.PlayRunners$class.running(Helpers.scala:76)
[error] play.it.http.websocket.NettyWebSocketSpec$.running(WebSocketSpec.scala:29)
[error] play.it.http.websocket.WebSocketSpec$class.withServer(WebSocketSpec.scala:44)
[error] play.it.http.websocket.NettyWebSocketSpec$.withServer(WebSocketSpec.scala:29)
[error] play.it.http.websocket.WebSocketSpec$class.closeWhenTheConsumerIsDone(WebSocketSpec.scala:130)
[error] play.it.http.websocket.NettyWebSocketSpec$.closeWhenTheConsumerIsDone(WebSocketSpec.scala:29)
[error] play.it.http.websocket.WebSocketSpec$$anonfun$5$$anonfun$apply$97$$anonfun$apply$110.apply(WebSocketSpec.scala:381)
[error] play.it.http.websocket.WebSocketSpec$$anonfun$5$$anonfun$apply$97$$anonfun$apply$110.apply(WebSocketSpec.scala:381)
[error] play.it.ServerIntegrationSpecification$$anonfun$around$1.apply(ServerIntegrationSpecification.scala:31)
[error] play.it.ServerIntegrationSpecification$class.around(ServerIntegrationSpecification.scala:31)
[error] play.it.http.websocket.NettyWebSocketSpec$.around(WebSocketSpec.scala:29)

@benmccann it is not a test flake. I was able to reproduce it locally. I will take a look tomorrow. ;-)

@marcospereira did you find the issue here?

@gmethvin did not had time to invest in this PR the last couple days.

@gmethvin,

Build is green and everything is working as expected after a rebase to master. Probably the test failure was related to some deprecated code (removed by @jroper). So this is safe to merge for master, but it MUST NOT be backported to 2.5.x as is.

@marcospereira Will you provide a PR for backporting?

@mkurz probably not until next week. I'm using some spare time just to keep track of my current open PR. If you have time, feel free to backport it. ;-)

The upgrade to akka 2.4.3 is not backport to play 2.5.2. Play 2.5.2 still depends on akka 2.4.2.

@wjtan Yes, I just noticed this. I thought we had backported this. Anyway, the workaround is very simple: just explicitly add akka 2.4.3 (or 2.4.4) as a dependency in your project.