Add check for play.editor setting #6009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26a9d13 to
e867beb
Compare
| "link the error line if play.editor is configured" in { | ||
| // This path happens from play.core.server.Server.getHandlerFor: | ||
| // | ||
| // def logExceptionAndGetResult(e: Throwable): Left[Future[Result], Nothing] = { |
e867beb to
8259ab2
Compare
Member
Author
|
@benmccann comment deleted |
Member
|
2.5.x: 41f8c14 |
This was referenced Jun 23, 2016
wsargent
added a commit
to wsargent/playframework
that referenced
this pull request
Aug 1, 2016
Fixes playframework#5270 Updates documentation to reflect fix made in playframework#6009
gmethvin
pushed a commit
that referenced
this pull request
Aug 2, 2016
wsargent
added a commit
to wsargent/playframework
that referenced
this pull request
Oct 25, 2016
* [doc] fix play.editor configuration documentation Fixes playframework#5270 Updates documentation to reflect fix made in playframework#6009 * Update documentation based on feedback * Add PLAY_EDITOR environment variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #3892
Purpose
The
play.editorsetting was not being applied -- this change ensures that error pages can read the value in for the DefaultHttpErrorHandler singleton object.