Optional entity length for range requests #6052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
lgtm (the only thing which could maybe be better is that the methods without the content length should have a note that these should only be used if the content length could not be determined, but that is just for RFC correctness and needs only be a small note inside a comment, so nothing non trivial..) |
Member
|
@marcospereira LGTM. Can you resolve the conflicts and merge? |
Also adds support for input streams.
Member
Author
|
@gmethvin rebased and green build. ;-) |
gmethvin
pushed a commit
that referenced
this pull request
Apr 27, 2016
Also adds support for input streams.
Member
|
2.5.x: 17bf0f0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Purpose
Support optional entity-length for range requests, as documented by RFC 7233. This PR can be safety backported to 2.5.x after being merged.
References
See #5961.
@schmitch and @mkurz you may be interested in reviewing this. ;-)