Refactoring to use Java 8 Streams API #6053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private Object body = null; | ||
| private Map<String, Collection<String>> headers = new HashMap<String, Collection<String>>(); | ||
| private Map<String, List<String>> queryParameters = new HashMap<String, List<String>>(); | ||
| private Map<String, List<String>> headers = new HashMap<>(); |
Member
Author
There was a problem hiding this comment.
Yep. Most of attributes here are eligible to be final. I will added it.
Contributor
There was a problem hiding this comment.
If play-java-ws has a dependency on Guava then this could be simplified a bit by using an ArrayListMultimap
Member
|
Wow this is great 👍 Saves us about 100 lines of code. |
Member
|
@marcospereira It should be ok to backport this, right? |
Member
Author
|
@gmethvin yes. |
Member
|
2.5.x: 10c5c01 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some refactoring to use Java 8 stream APIS and have more concise code.