Do not add Content-Disposition header when serving assets #6058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -455,7 +455,7 @@ class AssetsBuilder(errorHandler: HttpErrorHandler) extends Controller { | |||
| val stream = connection.getInputStream | |||
| val source = StreamConverters.fromInputStream(() => stream) | |||
| // TODO this is a lie - stream.available does not necessarily return the length of the file, to do that we | |||
Member
|
2.5.x: 0179ed6 |
|
Any idea on a time frame when this will get released in 2.5.x? |
Member
|
@justinnichols 2.5.3 is out now. Making the announcement soon. |
|
Thanks so much, @gmethvin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Purpose
Assets controller was adding a
Content-Dispositionheader when serving files. This is not necessary and also changes the way this was working before. This must be backported.References
See discussion at gitter channel: https://gitter.im/playframework/playframework?at=5715069c2c9711166432efb1