Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Doc fix: Correctly look up validation errors in messages #6068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gmethvin merged 1 commit into from
Apr 27, 2016
Merged

Doc fix: Correctly look up validation errors in messages #6068

gmethvin merged 1 commit into from
Apr 27, 2016

Conversation

@mkurz
Copy link
Member

@mkurz mkurz commented Apr 21, 2016

Only displaying error.message is wrong. Right now the documentation doesn't take the validation error arguments into account.

We for example create (global) ValidationErrors (the java ones) like this:

new ValidationError("", "msgkey", Arrays.asList("msgarg1", "msgarg2"));

@mkurz
Copy link
Member Author

mkurz commented Apr 21, 2016 •
edited
Loading

Forgot:
The messages file looks like this:

msgkey=Some message making use of {0} and {1}

I think that's how it is supposed to work with ValidationError.

@mkurz mkurz force-pushed the validationDocFix branch from 5ae34eb to 4b66fd6 Compare April 21, 2016 19:56
@mkurz mkurz force-pushed the validationDocFix branch from 4b66fd6 to 6b5c7c2 Compare April 22, 2016 08:04
@gmethvin gmethvin merged commit 8aee222 into playframework:master Apr 27, 2016
@gmethvin
Copy link
Member

gmethvin commented Apr 27, 2016

2.5.x: c08bd20

@mkurz mkurz deleted the validationDocFix branch April 27, 2016 05:01
@gmethvin gmethvin added this to the 2.5.3 milestone Apr 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.5.3

Development

Successfully merging this pull request may close these issues.

2 participants

@mkurz @gmethvin