Trigger 400 error if path is null #6093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@gmethvin can we have a test here? Also, is Akka Server already returning a 400 when path is null? |
Member
Author
|
@marcospereira The Akka server has its own parsing logic for the URI so if it doesn't work it would have to be fixed in Akka anyway. I'll test and see but I don't think it's needed for this PR. |
Member
Author
|
@marcospereira I don't think we have a facility to easily send raw HTTP requests in tests (where, for example, I can send a malformed URL). I'm going to merge this now since I think it should be in 2.5.3. At worst it changes one type of error (500 because of an NPE somewhere in your code) to another type of error (400) |
Member
Author
|
2.5.x: 4d24acb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the path of the URI is null, it can cause NPEs in the router and in user code. This normally doesn't happen in an HTTP request, but it seems it can happen if you send a URI which does not have a path component defined, for example:
It seems appropriate to send a 400 error in this case. I've done that here by throwing an exception.
This was discussed on the mailing list as well: https://groups.google.com/forum/#!topic/play-framework/-bsLA-UTyis.