Fix @deprecated annotations #6103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can you send this PR against the master branch instead? We only merge things into other branches after they're in master |
Member
|
@benmccann Actually these methods have been removed in master so sending a PR to 2.5.x is okay here. @avdv Can you update the ones that say 2.5 to say 2.5.0? |
Contributor
|
Ahh, good point. Thanks |
The arguments of the @deprecated annotation are reversed in the WS lib, so the documentation looks a bit funny: ``` Deprecated (Since version Use WS.stream() instead.) 2.5.0 ```
Contributor
Author
Sure thing. Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes scaladoc for deprecated methods.
Before:
After:
Note, according to
git grep -l '@deprecated\s*(\s*"\d'these were the only occurrences.