Move environment definition into code example #6148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since environment is referenced in the parser definition, it needs to be included in the documented snippet of code. It took me a few minutes of head scratching to work out what this should be, and I was heartened to see that I ended up with the exact same definition as is in the code, it's just not included in the code sample on the page.
Member
|
Does this need forward porting? |
wsargent
pushed a commit
to wsargent/playframework
that referenced
this pull request
Jun 5, 2016
Since environment is referenced in the parser definition, it needs to be included in the documented snippet of code. It took me a few minutes of head scratching to work out what this should be, and I was heartened to see that I ended up with the exact same definition as is in the code, it's just not included in the code sample on the page.
mkurz
pushed a commit
that referenced
this pull request
Jun 5, 2016
Since environment is referenced in the parser definition, it needs to be included in the documented snippet of code. It took me a few minutes of head scratching to work out what this should be, and I was heartened to see that I ended up with the exact same definition as is in the code, it's just not included in the code sample on the page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Fixes
Purpose
Corrects the code example shown in the documentation for using a wsclient without injecting the configuration through play.
Background Context
The code on the documentation page would not compile without this change.