Fixes #4796 makes acceptAnyCertificate work #6170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@schmitch Maybe we should add a warning when loose ssl configuration is used in production. I think this should probably go in SSLConfigParser though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #4796
Purpose
Actually it makes acceptAnyCertificate working
Background Context
In Play 2.4 upwards Play added a JsseSslContext and relied on Netty 4 / Asynchttpclient 2 while everything worked, the certificate handling changed and made it impossible to run under "really" loose SSL setups.
At the moment there aren't tests for this, but it will be actually hard to implement.
There is one way but since I would need to work around some things I didn't. Actually setting up a play instance with -Dhttps.port=9443 and point a ws.url to itself it will actually fail with a SSL Error so there would be a way to test, however the WS Test client doesn't rely on a typesafe config (
playframework/framework/src/play-ws/src/main/scala/play/api/test/WSTestClient.scala
Line 65 in 9a06b9a