Add java.time.LocalDate support to Forms Mapping #6249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi @wsargent could you or anyone kindly have a look at this and let me know what you think. Thanks! |
Member
|
Hi @deVIAntCoDE Thanks! I'm at ScalaDays Berlin right now, but I'll look at it when I can. |
Contributor
Author
|
👍 |
Member
|
LGTM. Should we expand this to support other types at |
Contributor
Author
|
Yeah good point. I'll expand this to support the rest of types as well. |
1b58942 to
0baf07a
Compare
0baf07a to
e84debd
Compare
gmethvin
pushed a commit
that referenced
this pull request
Jun 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Fixes
Fixes No java.time.LocalDate form mappings available
Purpose
Form mappings do not support java.time.LocalDate. This PR adds this functionality for form mapping
Background Context
Currently, to use java.time.LocalDate in domain objects mapped to form definitions, one has to take in the LocalDate in as a joda LocalDate and convert to java.time LocalDate. By introducing a localdate mapping for form data, one can use the new java.time.LocalDate directly.