Fixes #6152 by customizing the HttpContentDecompressor #6257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
No need to merge this. It's fixed in Netty already netty/netty#5428 |
Contributor
Author
|
Actually I think it's best to at least add the test for it and mark it pendingUntilFixed. |
Member
|
Yeah, I guess whenever 4.0.38.Final is released we'll be fine, but if we want to do a Play release before that it'd be good to fix the bug here. Perhaps we should just add the workaround and create an issue to remove it when netty fixes it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6152
This implements what jroper suggested playframework/netty-reactive-streams#19 (comment)
Akka Test is pending until fixed (it can't decode deflate/gzip yet)