Fixes #6351 made the parameter onClose of sendFile working again #6362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@schmitch Yeah, for the backport let's just use |
schmitch
added a commit
that referenced
this pull request
Jul 28, 2016
wsargent
pushed a commit
to wsargent/playframework
that referenced
this pull request
Oct 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #6351
Purpose
Makes onClose of Results#sendFile working
Background Context
Actually if somebody has an idea to make the Unittest better, tell me
Actually if we backport it we could actually put
play.api.libs.concurrent.Execution.defaultContextas a paramter directly instead of having aimplicit ec: ExecutionContext