Ensure that custom signature calculator works in Java #6455
+38
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmethvin
pushed a commit
that referenced
this pull request
Aug 18, 2016
wsargent
added a commit
to wsargent/playframework
that referenced
this pull request
Aug 29, 2016
wsargent
added a commit
to wsargent/playframework
that referenced
this pull request
Oct 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes the hardcoding of OAuth SignatureCalculator reported in https://groups.google.com/d/topic/play-framework/onkvUUMrg8w/discussion
Purpose
Leverages the AHC 2.0 API so an AHC SignatureCalculator is passed through if the type matches. This is only applicable in Java -- the Scala API works fine.
Added tests for both Java and Scala just to double check.