Document Default controller in routing docs #6520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Oh, looks like the docs are compiled, too. I took a look, but I'm running out of time to dig into how to set this straight. Any pointers welcome :-) |
Member
|
You need to specify the full path to the controller type in routes: https://travis-ci.org/playframework/playframework/builds/157275557#L3208 |
Contributor
Author
| import play.api.mvc.Controller | ||
| import _root_.controllers.{Default => PlayDefault} | ||
|
|
||
| class Default extends Controller { |
Contributor
Author
There was a problem hiding this comment.
It'd be great not to have to declare a new controller myself here, and just import the Default controller and be done with it.
Member
There was a problem hiding this comment.
@mikem Why not just
class Default extends _root_.controllers.Default?
It's somewhat annoying that we have to do this. I never really liked the fact that we have stuff in a top-level controllers package either (I would rather it be play.controllers or something).
Also: - correct the return code in the `Default` controller's `redirect` action Scaladoc - fix ScalaSirdRouter link
Also, tests for routing to Default controller.
c47c406 to
2614316
Compare
Contributor
Author
gmethvin
pushed a commit
that referenced
this pull request
Sep 12, 2016
* Document Default controller in routing docs Also: - correct the return code in the `Default` controller's `redirect` action Scaladoc - fix ScalaSirdRouter link * Documentation compiles again Also, tests for routing to Default controller. * Simplify Default controllers
wsargent
pushed a commit
to wsargent/playframework
that referenced
this pull request
Oct 25, 2016
* Document Default controller in routing docs Also: - correct the return code in the `Default` controller's `redirect` action Scaladoc - fix ScalaSirdRouter link * Documentation compiles again Also, tests for routing to Default controller. * Simplify Default controllers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the
Defaultcontroller useful and thought it'd be good to mention it in the routing documentation. This PR does that, along with some other minor documentation fixes.