fixes websockets on netty #6534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| push(remoteOut, close) | ||
| completeStage() | ||
| // And complete both remote out and remote in | ||
| complete(remoteOut) |
Contributor
Author
There was a problem hiding this comment.
if that won't help we can basically just add a netty: Boolean and remove these two completly than netty will close the upstream by himself. Which is basically a little bit smoother since netty knows when he flushes the Message.
Member
|
@schmitch lgtm. Can you backport to 2.5.x? |
Contributor
Author
|
yes |
schmitch
added a commit
that referenced
this pull request
Sep 8, 2016
Contributor
Author
|
Backport: 00e016f (commited directly) |
|
Not a helpful pull request title. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6504
Edit: Fix is just 3 Lines https://github.com/playframework/playframework/pull/6534/files#diff-745ef9331ba1901efedd1607f6675eeaR183
Basically we can also omit complet/cancel for netty (not for akka) if necessary.