Trim digest of asset after reading it. fixes #6538 #6539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If using external tools to generate the digest of an asset (e.g. md5sum main.css > main.css.md5), it may happen that the tool adds non printable characters (like \n) after the digest. This results in URLs generated like: /assets/styles/dc5672cb5071cd31a6fb6d670807161c -main.css instead of /assets/styles/dc5672cb5071cd31a6fb6d670807161c-main.css Proposed solution: Trim the digest read from the digest file.
Member
|
Seems reasonable. I think I've run into this issue before actually. I don't think there's a good reason for a digest to have spaces so I don't see a downside. |
Member
|
Should we backport this? |
gmethvin
pushed a commit
that referenced
this pull request
Sep 14, 2016
If using external tools to generate the digest of an asset (e.g. md5sum main.css > main.css.md5), it may happen that the tool adds non printable characters (like \n) after the digest. This results in URLs generated like: /assets/styles/dc5672cb5071cd31a6fb6d670807161c -main.css instead of /assets/styles/dc5672cb5071cd31a6fb6d670807161c-main.css Proposed solution: Trim the digest read from the digest file.
Member
|
backported to 2.5.x: d2c4cad |
wsargent
pushed a commit
to wsargent/playframework
that referenced
this pull request
Oct 25, 2016
…framework#6539) If using external tools to generate the digest of an asset (e.g. md5sum main.css > main.css.md5), it may happen that the tool adds non printable characters (like \n) after the digest. This results in URLs generated like: /assets/styles/dc5672cb5071cd31a6fb6d670807161c -main.css instead of /assets/styles/dc5672cb5071cd31a6fb6d670807161c-main.css Proposed solution: Trim the digest read from the digest file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If using external tools to generate the digest of an asset (e.g. md5sum main.css > main.css.md5), it may happen that the tool adds non printable characters (like \n) after the digest.
This results in URLs generated like:
/assets/styles/dc5672cb5071cd31a6fb6d670807161c
-main.css
instead of
/assets/styles/dc5672cb5071cd31a6fb6d670807161c-main.css
Proposed solution: Trim the digest read from the digest file.