[2.5.x] reverts matrix params in query strings #6560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnbak
approved these changes
Sep 16, 2016
arnbak
left a comment
There was a problem hiding this comment.
I think this is the right thing to do, some unwanted side effects appeared with this change.
arnbak
approved these changes
Sep 16, 2016
gmethvin
approved these changes
Sep 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually this reverts back how query strings were handled in previous versions of Play 2.5.x. I guess most of the time the matrix params aren't a good idea and will probably make more problems than they will be helpful.
I guess to get the Uri Encoding / Decoding right, we should create Docs that explains the why and how (which I will do in #6524 where we also use a library for uri encoding and decoding), that's the best way forward.
I'm sorry for all people that rely on that, that I got it that wrong and introduced a quite breaking change in 2.5.x mid term.
Edit: I guess it's fine to set the mima filter.