2.4.x Backport to fix issue #6272 #6595
Conversation
|
Hi @MarkPaxton, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
gmethvin
left a comment
There was a problem hiding this comment.
Thanks @MarkPaxton. Once you've fixed the build I think this is good.
|
@gmethvin I'm not actually sure why the test suite fails as it doesn't appear to be against anything I changed - does the current test expect the 2.5.x branch only? |
|
It looks like we just added tests that used If you add the play-specs2 dependency and import WithApplication it should work fine. |
|
@gmethvin It looks like the backport of the fix hasn't worked as now the new tests are failing |
mkurz
left a comment
There was a problem hiding this comment.
@MarkPaxton Same here - you forgot to change a return statement. That's why your tests fail for this branch.
Get rid of the None() in Line 416 in Form.java and the tests should run fine.
Thanks again to @mkurz, see PR playframework#6596
Pull Request Checklist
Helpful things
Fixes
Fixes #6272
Purpose
This is a backport of the change in the 2.5.x branch to fix the issue as above
Background Context
This was suggested as part of issue #6592
References
#6592