Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@tsuyoshizawa
Copy link
Contributor

Pull Request Checklist

  • Have you read How to write the perfect pull request?
  • Have you read through the contributor guidelines?
  • Have you signed the Lightbend CLA?
  • Have you [squashed your commits]? (Optional, but makes merge messages nicer.)
  • Have you added copyright headers to new files?
  • Have you checked that both Scala and Java APIs are updated?
  • Have you updated the documentation for both Scala and Java sections?
  • Have you added tests for any changed functionality?

Purpose

Evolutions doesn't work with query parameter.

http://localhost:9000/search?q=aaa

When url already has query parameters on Evolution, Play can't catch a redirect parameter as a query parameter in apply button.

http://localhost:9000/search?q=aaa/@evolutions/apply/default?redirect=http%3A%2F%2Flocalhost%3A8484%2Fsearch%3Fq%3Daaa

Because ? character is duplicated in redirect url.

My PR removes the search query from url in apply button for Evolution.

http://localhost:9000/search/@evolutions/apply/default?redirect=http%3A%2F%2Flocalhost%3A8484%2Fsearch%3Fq%3Daaa

Copy link
Member

@gmethvin gmethvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tsuyoshizawa

@gmethvin gmethvin merged commit d96d42e into playframework:master Sep 26, 2016
@tsuyoshizawa tsuyoshizawa deleted the fix-query-evolutions branch September 27, 2016 00:37
wsargent pushed a commit to wsargent/playframework that referenced this pull request Oct 18, 2016
wsargent pushed a commit to wsargent/playframework that referenced this pull request Oct 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants