Fix path to activator in document #6655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmitch
suggested changes
Oct 18, 2016
| ``` | ||
|
|
||
| Make sure that the `activator` script is executable. If it's not: | ||
| Make sure that the `bin/activator` script is executable. If it's not: |
Contributor
There was a problem hiding this comment.
Actually this bin/ is probably not correct since the export PATH is export PATH=/path/to/activator-x.x.x/bin:$PATH which includes the bin Folder.
Contributor
Author
There was a problem hiding this comment.
Thanks. It makes sense to remove bin/.
schmitch
approved these changes
Oct 18, 2016
wsargent
pushed a commit
to wsargent/playframework
that referenced
this pull request
Oct 25, 2016
* Fix path to activator * remove path to activator since it is in $PATH
mkurz
pushed a commit
that referenced
this pull request
Dec 2, 2016
* Fix path to activator * remove path to activator since it is in $PATH
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply fixes 2 lines in documentation/manual/gettingStarted/Installing.md,
where the path to activator was wrong.