Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@rethab
Copy link
Contributor

@rethab rethab commented Nov 3, 2016

Pull Request Checklist

  • Have you read How to write the perfect pull request?
  • Have you read through the contributor guidelines?
  • Have you signed the Lightbend CLA?
  • Have you [squashed your commits]? (Optional, but makes merge messages nicer.)
  • Have you added copyright headers to new files?
  • Have you checked that both Scala and Java APIs are updated?
  • Have you updated the documentation for both Scala and Java sections?
  • Have you added tests for any changed functionality?

Helpful things

Fixes

Fixes #xxxx

Purpose

What does this PR do?

Background Context

It adds a tiny bit to the akka documentation clarifying how the child actor gets its name, because in the existing example the key parameter is used both as a parameter to the factory as well as the actor's name.

References

Are there any relevant issues / PRs / mailing lists discussions?

  • this confused me a lot when I saw that the key is passed twice.

  - this confused me a lot when I saw that the key is passed twice.
@gmethvin gmethvin merged commit 12d02be into playframework:master Nov 3, 2016
gmethvin pushed a commit that referenced this pull request Nov 3, 2016
- this confused me a lot when I saw that the key is passed twice.
@mkurz mkurz added this to the 2.5.10 milestone Dec 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants