Parse IPv4-mapped IPv6 addresses in forward headers #6698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes playframework#6629. I also changed to use Guava's IP address parser instead of the standard Java parser. The Java parser will make DNS lookups for non-IP addresses. I don't think we need DNS lookups so the Guava parser is probably better.
gmethvin
approved these changes
Nov 4, 2016
gmethvin
pushed a commit
that referenced
this pull request
Nov 12, 2016
Fixes #6629. I also changed to use Guava's IP address parser instead of the standard Java parser. The Java parser will make DNS lookups for non-IP addresses. I don't think we need DNS lookups so the Guava parser is probably better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6629.
I also changed to use Guava's IP address parser instead of the standard Java parser. The Java parser will make DNS lookups for non-IP addresses. I don't think we need DNS lookups so the Guava parser is probably better.
Cc @swoopster-sb.